From 935ccd6335bf9e090ef6a73ca2f425c8809c5b9d Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 15 Jun 2018 00:22:52 +0100 Subject: [PATCH] services: Add linebreak between regular and spread parameter Follows-up 1e680456b4, which removed some array_merge/call_user_func abstraction, but improved readability a lot, but the absence of a line break makes it slightly less obvious how and what parameters are being passed. It's usually either comma-separated segments on the same line that as the open parenthesis, or one expression per line. Change-Id: Ic388cf41ed3ed60d9b47c04392242e40cdcb69b0 --- includes/services/ServiceContainer.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/includes/services/ServiceContainer.php b/includes/services/ServiceContainer.php index c98b7da79c..7814194fea 100644 --- a/includes/services/ServiceContainer.php +++ b/includes/services/ServiceContainer.php @@ -356,7 +356,8 @@ class ServiceContainer implements DestructibleService { private function createService( $name ) { if ( isset( $this->serviceInstantiators[$name] ) ) { $service = ( $this->serviceInstantiators[$name] )( - $this, ...$this->extraInstantiationParams + $this, + ...$this->extraInstantiationParams ); // NOTE: when adding more wiring logic here, make sure copyWiring() is kept in sync! } else { -- 2.20.1